Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the calculation of defaultCF - block-cache-size #3420

Merged
merged 3 commits into from
Jul 29, 2020
Merged

Unify the calculation of defaultCF - block-cache-size #3420

merged 3 commits into from
Jul 29, 2020

Conversation

glkappe
Copy link
Contributor

@glkappe glkappe commented May 31, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

This PR is manually cherry-picked to master in #4086.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@sre-bot sre-bot added the contribution This PR is from a community contributor. label May 31, 2020
@TomShawn TomShawn changed the base branch from release-4.0 to master June 1, 2020 02:31
@TomShawn TomShawn changed the base branch from master to release-4.0 June 1, 2020 02:31
@TomShawn TomShawn changed the title 统一 defaultCF - block-cache-size 计算方式 Unify the calculation of defaultCF - block-cache-size Jun 1, 2020
@TomShawn TomShawn added size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Jun 1, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Jun 1, 2020

@glkappe Please rebase this PR to the master branch if it applies to both master and release-4.0. Please also involve a technical review.

@glkappe glkappe changed the base branch from release-4.0 to master June 1, 2020 14:39
@TomShawn TomShawn changed the base branch from master to release-4.0 July 24, 2020 06:41
@ti-srebot
Copy link
Contributor

@gengliqi,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

TomShawn
TomShawn approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2020
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jul 29, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@TomShawn TomShawn mentioned this pull request Jul 29, 2020
Merged
5 tasks
@ti-srebot ti-srebot merged commit f7b4321 into pingcap:release-4.0 Jul 29, 2020
@Joyinqin Joyinqin mentioned this pull request Jul 30, 2020
Merged
9 tasks
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Jul 30, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR’s assignee is translating this PR. label Jul 30, 2020
@ti-srebot ti-srebot mentioned this pull request Jul 30, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengliqi gengliqi gengliqi approved these changes

@TomShawn TomShawn TomShawn approved these changes

@zhangjinpeng87 zhangjinpeng87 Awaiting requested review from zhangjinpeng87

Assignees

@Joyinqin Joyinqin

Labels
contribution This PR is from a community contributor. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@glkappe @TomShawn @ti-srebot @Joyinqin @gengliqi @sre-bot