Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add document of dumpling, the new export tool #3151
Add document of dumpling, the new export tool #3151
Changes from 8 commits
764f465
df46891
feb154c
7b767a5
d784de9
44b09f7
f3821cc
446d081
de2afb9
0e03726
63012c8
66bd9c8
a39267a
4be6349
1ab5ee9
e95c470
7276c64
d50d517
09f0854
8818321
10370c0
325c78a
4fe19d4
3b389f1
134f954
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文档标题直接改成
使用 dumpling/TiDB Lightning 进行备份与恢复
怎么样?下面就不用再特殊说明使用 dumpling 替换 mydumper 了
@3pointer 感觉咋样?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果 dumpling 定位是已经可以代替 mydumper 进行 tidb 的备份,建议
dumpling/TiDB Lightning 进行备份与恢复
,然后 mydumper 独立一个文档,用Deprecated
标识出来。另外感觉缺一个说明,比如,什么时候选择 dumpling+lightning ,什么时候选择 BR备份,什么时候用 CDC 增量备份,什么时候用 BR 增量备份
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在 tools 的 use guide 里有这个说明
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
放在 tools 的 guide 里不太合适,用户从备份这里进来,会错过,应该在备份这里加一个总述