Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiflash: add more explanation on how to clear syncing rules about tiflash in pd #2838

Merged
merged 7 commits into from
Apr 20, 2020

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Apr 20, 2020

What is changed, added or deleted? (Required)

add more explanation on how to clear syncing rules about tiflash in pd.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@lidezhu lidezhu requested review from solotzg and yikeke April 20, 2020 10:17
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

reference/tiflash/maintain.md Outdated Show resolved Hide resolved
reference/tiflash/maintain.md Outdated Show resolved Hide resolved
lidezhu and others added 2 commits April 20, 2020 18:32
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added the translation/doing This PR’s assignee is translating this PR. label Apr 20, 2020
Copy link
Contributor

@solotzg solotzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2020

CLA assistant check
All committers have signed the CLA.

@lidezhu lidezhu merged commit b20120f into pingcap:master Apr 20, 2020
@lidezhu lidezhu deleted the delete-tiflash-store branch April 20, 2020 11:07
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Apr 20, 2020
…lash in pd (pingcap#2838)

* Add more explanation about how to clear syncing rules in tiflash

* Fix comment

* Update reference/tiflash/maintain.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update reference/tiflash/maintain.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update reference/tiflash/maintain.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* remove weird codes

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Tong Zhigao <solotzg@163.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2020

cherry pick to release-3.1 in PR #2839

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Apr 20, 2020
…lash in pd (pingcap#2838)

* Add more explanation about how to clear syncing rules in tiflash

* Fix comment

* Update reference/tiflash/maintain.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update reference/tiflash/maintain.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update reference/tiflash/maintain.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* remove weird codes

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Tong Zhigao <solotzg@163.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2020

cherry pick to release-4.0 in PR #2840

yikeke added a commit that referenced this pull request Apr 20, 2020
…lash in pd (#2838) (#2839)

* Add more explanation about how to clear syncing rules in tiflash

* Fix comment

* Update reference/tiflash/maintain.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update reference/tiflash/maintain.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update reference/tiflash/maintain.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* remove weird codes

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Tong Zhigao <solotzg@163.com>

Co-authored-by: lidezhu <47731263+lidezhu@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Tong Zhigao <solotzg@163.com>
yikeke added a commit that referenced this pull request Apr 20, 2020
…lash in pd (#2838) (#2840)

* Add more explanation about how to clear syncing rules in tiflash

* Fix comment

* Update reference/tiflash/maintain.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update reference/tiflash/maintain.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update reference/tiflash/maintain.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* remove weird codes

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Tong Zhigao <solotzg@163.com>

Co-authored-by: lidezhu <47731263+lidezhu@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Tong Zhigao <solotzg@163.com>

手动在 PD 中清除同步规则的步骤如下:

1. 查询当前 PD 实例中所有与 TiFlash 相关的的数据同步规则。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. 查询当前 PD 实例中所有与 TiFlash 相关的的数据同步规则
1. 查询当前 PD 实例中所有与 TiFlash 相关的数据同步规则

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open a PR to fix this typo? @lidezhu

@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 21, 2020
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
…lash in pd (pingcap#2838)

* Add more explanation about how to clear syncing rules in tiflash

* Fix comment

* Update reference/tiflash/maintain.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update reference/tiflash/maintain.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update reference/tiflash/maintain.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* remove weird codes

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Tong Zhigao <solotzg@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants