Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference: add new option for tidb_replica_read #2762

Merged
merged 3 commits into from
May 14, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Apr 15, 2020

What is changed, added or deleted? (Required)

Add an new option for tidb_replica_read.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs This PR is translated from a PR in pingcap/docs. size/small Changes of a small size. needs-cherry-pick-3.1 labels Apr 15, 2020
@ran-huang ran-huang added the status/PTAL This PR is ready for reviewing. label Apr 20, 2020
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn requested review from hicqu and removed request for hicqu April 21, 2020 13:25
@TomShawn
Copy link
Contributor Author

@hicqu PTAL

@sre-bot
Copy link
Contributor

sre-bot commented Apr 22, 2020

@ran-huang, @hicqu, PTAL.

@sre-bot
Copy link
Contributor

sre-bot commented Apr 25, 2020

@ran-huang, @hicqu, PTAL.

2 similar comments
@sre-bot
Copy link
Contributor

sre-bot commented Apr 27, 2020

@ran-huang, @hicqu, PTAL.

@sre-bot
Copy link
Contributor

sre-bot commented Apr 30, 2020

@ran-huang, @hicqu, PTAL.

@TomShawn TomShawn merged commit b70c9d9 into pingcap:master May 14, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 14, 2020
* reference: add new option for tidb_replica_read

* Update reference/performance/follower-read.md
@sre-bot
Copy link
Contributor

sre-bot commented May 14, 2020

cherry pick to release-3.1 in PR #3105

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 14, 2020
* reference: add new option for tidb_replica_read

* Update reference/performance/follower-read.md
@sre-bot
Copy link
Contributor

sre-bot commented May 14, 2020

cherry pick to release-4.0 in PR #3106

TomShawn added a commit that referenced this pull request May 14, 2020
* reference: add new option for tidb_replica_read

* Update reference/performance/follower-read.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn deleted the replica-new-option branch May 14, 2020 09:52
TomShawn added a commit that referenced this pull request May 14, 2020
* reference: add new option for tidb_replica_read

* Update reference/performance/follower-read.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants