Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-binlog: change bidirectional replication file name and image #2549

Merged
merged 5 commits into from
Apr 24, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Mar 24, 2020

What is changed, added or deleted? (Required)

  • Change the file name of the bidirectional replication document.
  • Change the image text to Chinese.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version, including v4.0 changes for now)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. size/small Changes of a small size. needs-cherry-pick-3.1 status/WIP This PR is still working in progress. labels Mar 24, 2020
@TomShawn TomShawn self-assigned this Mar 24, 2020
@yikeke yikeke self-requested a review April 14, 2020 07:35
@yikeke yikeke added the status/require-change Needs the author to address comments. label Apr 14, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2020

@TomShawn, please update your pull request.

2 similar comments
@sre-bot
Copy link
Contributor

sre-bot commented Apr 22, 2020

@TomShawn, please update your pull request.

@sre-bot
Copy link
Contributor

sre-bot commented Apr 22, 2020

@TomShawn, please update your pull request.

@TomShawn TomShawn removed the status/WIP This PR is still working in progress. label Apr 24, 2020
@TomShawn
Copy link
Contributor Author

@yikeke @july2993 PTAL

Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomShawn
Copy link
Contributor Author

@yikeke Comments addressed, PTAL again, thanks!

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented Apr 24, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 24, 2020

/run-all-tests

@yikeke yikeke merged commit 7fa4ef4 into pingcap:master Apr 24, 2020
sre-bot added a commit to sre-bot/docs-cn that referenced this pull request Apr 24, 2020
…ngcap#2549)

* tidb-binlog: change bidirectional replicaition doc name and image

* update image

* address comments

* Apply suggestions from code review

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 24, 2020

cherry pick to release-3.0 in PR #2880

sre-bot added a commit to sre-bot/docs-cn that referenced this pull request Apr 24, 2020
…ngcap#2549)

* tidb-binlog: change bidirectional replicaition doc name and image

* update image

* address comments

* Apply suggestions from code review

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 24, 2020

cherry pick to release-3.1 in PR #2881

sre-bot added a commit to sre-bot/docs-cn that referenced this pull request Apr 24, 2020
…ngcap#2549)

* tidb-binlog: change bidirectional replicaition doc name and image

* update image

* address comments

* Apply suggestions from code review

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 24, 2020

cherry pick to release-4.0 in PR #2882

@TomShawn TomShawn deleted the bidire-repli branch April 24, 2020 08:41
TomShawn added a commit that referenced this pull request Apr 24, 2020
) (#2882)

* tidb-binlog: change bidirectional replication file name and image (#2549)

* tidb-binlog: change bidirectional replicaition doc name and image

* update image

* address comments

* Apply suggestions from code review

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>

* change alias version

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Apr 24, 2020
) (#2881)

* tidb-binlog: change bidirectional replication file name and image (#2549)

* tidb-binlog: change bidirectional replicaition doc name and image

* update image

* address comments

* Apply suggestions from code review

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>

* change alias version

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Apr 24, 2020
) (#2880)

* tidb-binlog: change bidirectional replication file name and image (#2549)

* tidb-binlog: change bidirectional replicaition doc name and image

* update image

* address comments

* Apply suggestions from code review

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>

* change alias version

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
…ngcap#2549)

* tidb-binlog: change bidirectional replicaition doc name and image

* update image

* address comments

* Apply suggestions from code review

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/require-change Needs the author to address comments. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants