-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidb-binlog: change bidirectional replication file name and image #2549
Conversation
@TomShawn, please update your pull request. |
2 similar comments
@TomShawn, please update your pull request. |
@TomShawn, please update your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yikeke Comments addressed, PTAL again, thanks! |
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
…ngcap#2549) * tidb-binlog: change bidirectional replicaition doc name and image * update image * address comments * Apply suggestions from code review Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
cherry pick to release-3.0 in PR #2880 |
…ngcap#2549) * tidb-binlog: change bidirectional replicaition doc name and image * update image * address comments * Apply suggestions from code review Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
cherry pick to release-3.1 in PR #2881 |
…ngcap#2549) * tidb-binlog: change bidirectional replicaition doc name and image * update image * address comments * Apply suggestions from code review Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
cherry pick to release-4.0 in PR #2882 |
) (#2882) * tidb-binlog: change bidirectional replication file name and image (#2549) * tidb-binlog: change bidirectional replicaition doc name and image * update image * address comments * Apply suggestions from code review Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com> * change alias version Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
) (#2881) * tidb-binlog: change bidirectional replication file name and image (#2549) * tidb-binlog: change bidirectional replicaition doc name and image * update image * address comments * Apply suggestions from code review Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com> * change alias version Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
) (#2880) * tidb-binlog: change bidirectional replication file name and image (#2549) * tidb-binlog: change bidirectional replicaition doc name and image * update image * address comments * Apply suggestions from code review Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com> * change alias version Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
…ngcap#2549) * tidb-binlog: change bidirectional replicaition doc name and image * update image * address comments * Apply suggestions from code review Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?