-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONTRIBUTING, resources, media: add Figma Guide #2462
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaitinChen
added
needs-cherry-pick-3.1
translation/from-docs
This PR is translated from a PR in pingcap/docs.
labels
Mar 13, 2020
@lilin90 Created a "figma-guide" folder in "media." Migrated all images to this folder. |
lilin90
reviewed
Mar 16, 2020
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@lilin90 Thanks. Updated. |
lilin90
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sre-bot
pushed a commit
to sre-bot/docs-cn
that referenced
this pull request
Mar 17, 2020
* CONTRIBUTING, resources, media: add Figma Guide * Update figma guide description * media, resources: create a "figma-guide" folder in "media" * Update CONTRIBUTING.md Co-Authored-By: Lilian Lee <lilin@pingcap.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>
4 tasks
cherry pick to release-2.1 in PR #2487 |
sre-bot
pushed a commit
to sre-bot/docs-cn
that referenced
this pull request
Mar 17, 2020
* CONTRIBUTING, resources, media: add Figma Guide * Update figma guide description * media, resources: create a "figma-guide" folder in "media" * Update CONTRIBUTING.md Co-Authored-By: Lilian Lee <lilin@pingcap.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>
4 tasks
cherry pick to release-3.0 in PR #2488 |
sre-bot
pushed a commit
to sre-bot/docs-cn
that referenced
this pull request
Mar 17, 2020
* CONTRIBUTING, resources, media: add Figma Guide * Update figma guide description * media, resources: create a "figma-guide" folder in "media" * Update CONTRIBUTING.md Co-Authored-By: Lilian Lee <lilin@pingcap.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>
4 tasks
cherry pick to release-3.1 in PR #2489 |
lilin90
added a commit
that referenced
this pull request
Mar 17, 2020
* CONTRIBUTING, resources, media: add Figma Guide * Update figma guide description * media, resources: create a "figma-guide" folder in "media" * Update CONTRIBUTING.md Co-Authored-By: Lilian Lee <lilin@pingcap.com> Co-authored-by: Lilian Lee <lilin@pingcap.com> Co-authored-by: Caitin <34535727+CaitinChen@users.noreply.github.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>
lilin90
added a commit
that referenced
this pull request
Mar 17, 2020
* CONTRIBUTING, resources, media: add Figma Guide * Update figma guide description * media, resources: create a "figma-guide" folder in "media" * Update CONTRIBUTING.md Co-Authored-By: Lilian Lee <lilin@pingcap.com> Co-authored-by: Lilian Lee <lilin@pingcap.com> Co-authored-by: Caitin <34535727+CaitinChen@users.noreply.github.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>
lilin90
added a commit
that referenced
this pull request
Mar 17, 2020
* CONTRIBUTING, resources, media: add Figma Guide * Update figma guide description * media, resources: create a "figma-guide" folder in "media" * Update CONTRIBUTING.md Co-Authored-By: Lilian Lee <lilin@pingcap.com> Co-authored-by: Lilian Lee <lilin@pingcap.com> Co-authored-by: Caitin <34535727+CaitinChen@users.noreply.github.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>
rleungx
pushed a commit
to rleungx/docs-cn
that referenced
this pull request
May 22, 2020
* CONTRIBUTING, resources, media: add Figma Guide * Update figma guide description * media, resources: create a "figma-guide" folder in "media" * Update CONTRIBUTING.md Co-Authored-By: Lilian Lee <lilin@pingcap.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Add Figma Quick Start GuideWhich TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?