Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference/security: add missing semicolon #2254

Merged
merged 2 commits into from
Feb 21, 2020
Merged

reference/security: add missing semicolon #2254

merged 2 commits into from
Feb 21, 2020

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Feb 19, 2020 •
edited by lilin90
Loading

What is changed, added or deleted?

What is the related PR or file link(s)?

  • Reference link(s):
  • This PR is to align with:
  • N/A (not applicable)

Which TiDB version(s) does your changes apply to?

  • All active versions: dev, v3.0, v2.1, v3.1
  • dev (the latest development version)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)
  • v3.1 (TiDB 3.1 versions)
  • v4.0 (TiDB 4.0 versions)
  • All active and inactive versions
  • N/A (not applicable)

Note: If your changes apply to multiple TiDB versions, make sure you update the documents in the corresponding version folders such as "dev", "v3.0", "v2.1" and "v3.1" in this PR.

  • Updated one version first. Will update other versions after I get two LGTMs.

@weekface weekface added the size/small Changes of a small size. label Feb 19, 2020
lilin90
lilin90 approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 changed the title tiny fix: add missing semicolon reference/security: add missing semicolon Feb 21, 2020
@lilin90 lilin90 added the translation/doing This PR’s assignee is translating this PR. label Feb 21, 2020
@lilin90 lilin90 merged commit dfd5624 into pingcap:master Feb 21, 2020
@ran-huang ran-huang added aligning and removed translation/doing This PR’s assignee is translating this PR. labels Feb 21, 2020
@ran-huang ran-huang mentioned this pull request Feb 21, 2020
Merged
12 tasks
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed aligning labels Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

Assignees

@ran-huang ran-huang

Labels
size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weekface @lilin90 @ran-huang