Skip to content

docs: clarify how to disable TiFlash MPP after v7.3 - #21966

Open
doc-claw-bot wants to merge 1 commit into
pingcap:release-8.5from
doc-claw-bot:docs/htap-disable-mpp-note-r85
Open

doc-claw-bot wants to merge 1 commit into
pingcap:release-8.5from
doc-claw-bot:docs/htap-disable-mpp-note-r85

Conversation

@doc-claw-bot

@doc-claw-bot doc-claw-bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

What is changed, added or deleted? (Required)

Clarify the instructions for disabling TiFlash MPP in explore-htap.md and tiflash/use-tiflash-mpp-mode.md.

For TiDB v7.3.0 and later, if users disable tidb_allow_mpp but still want TiFlash to execute queries, they also need to enable tidb_allow_tiflash_cop. Otherwise, queries might return errors.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • 文档
    • 补充 TiDB v7.3.0 及更高版本关闭 MPP 时的配置说明:若仍需使用 TiFlash 执行查询,需同时启用 tidb_allow_tiflash_cop;若不需要 TiFlash 执行查询,则仅需关闭 tidb_allow_mpp。
    • 说明未启用 tidb_allow_tiflash_cop 时,使用 TiFlash 执行查询可能报错。

@ti-chi-bot

ti-chi-bot Bot commented Oct 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qiancai for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2026
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: pingcap/docs-cn/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 71e57146-1680-4ac9-81fc-d0bf6c155703
📥 Commits

Reviewing files that changed from the base of the PR and between 30442c7 and 819680b.

📒 Files selected for processing (2)
  • explore-htap.md
  • tiflash/use-tiflash-mpp-mode.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

文档补充了 TiDB v7.3.0 及之后版本关闭 MPP 时的配置说明。若仍需 TiFlash 执行查询,还需启用 tidb_allow_tiflash_cop;否则只需关闭 MPP。

Changes

TiFlash MPP 配置说明

Layer / File(s) Summary
关闭 MPP 时的 TiFlash 配置
tiflash/use-tiflash-mpp-mode.md, explore-htap.md
文档说明,TiDB v7.3.0 及之后版本关闭 MPP 后,若仍需 TiFlash 执行查询,应设置 tidb_allow_tiflash_cop=1(或 ON);若不需要 TiFlash 执行查询,只需设置 tidb_allow_mpp=0(或 OFF)。

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 81968

Both guides give consistent configuration instructions for disabling MPP while optionally retaining TiFlash query execution; no merge-blocking issue remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 81968

The change affects 2 systems.

Changed systems: explore-htap.md, tiflash

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — explore-htap.md (service) was modified; 1 changed file maps to changed impact.
  • observed — tiflash (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in explore-htap.md: 关闭 MPP 的说明新增版本条件:TiDB v7.3.0 及之后版本若要继续由 TiFlash 执行查询,需将 tidb_allow_tiflash_cop 设为 ON,通过 Cop 或 BatchCop 协议;否则查询可能报错。原说明仅要求将 tidb_allow_mpp 设为 OFF。
  • observed — Modified behavior in tiflash/use-tiflash-mpp-mode.md: 新增关闭 MPP 的配置说明:在 TiDB v7.3.0 及之后版本中,若仍需 TiFlash 执行查询,示例同时设置 tidb_allow_mpp=0 和 tidb_allow_tiflash_cop=1;若不需要 TiFlash 执行查询,则说明只需设置 tidb_allow_mpp=0。这替换了原先不区分 TiFlash 执行需求、仅设置 tidb_allow_mpp=0 的说明和示例。
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 标题准确概括了主要变更,即澄清 TiDB v7.3 及之后版本中如何关闭 TiFlash MPP。标题简洁且与修改内容一致。
Description check ✅ Passed 描述说明了修改内容、适用版本、相关文件和参考链接,并勾选了 master 与 v8.5 分支。内容覆盖模板中的必填信息,整体完整。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@doc-claw-bot doc-claw-bot added translation/from-docs This PR is translated from a PR in pingcap/docs. type/bugfix This PR fixes a bug. area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. labels Oct 8, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. contribution This PR is from a community contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant