Repository navigation
docs: clarify how to disable TiFlash MPP after v7.3 - #21966
doc-claw-bot wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthrough文档补充了 TiDB v7.3.0 及之后版本关闭 MPP 时的配置说明。若仍需 TiFlash 执行查询,还需启用 ChangesTiFlash MPP 配置说明
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Other Merge Risk: ⚪ Minimal · up to Both guides give consistent configuration instructions for disabling MPP while optionally retaining TiFlash query execution; no merge-blocking issue remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What is changed, added or deleted? (Required)
Clarify the instructions for disabling TiFlash MPP in
explore-htap.mdandtiflash/use-tiflash-mpp-mode.md.For TiDB v7.3.0 and later, if users disable
tidb_allow_mppbut still want TiFlash to execute queries, they also need to enabletidb_allow_tiflash_cop. Otherwise, queries might return errors.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
tidb_allow_tiflash_cop;若不需要 TiFlash 执行查询,则仅需关闭tidb_allow_mpp。tidb_allow_tiflash_cop时,使用 TiFlash 执行查询可能报错。