Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable: tidb_pipelined_dml_resource_policy #19994

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ekexium
Copy link
Member

@ekexium ekexium commented Mar 5, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Added a system variable tidb_pipelined_dml_resource_policy

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

pingcap/tidb#57352

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: ekexium <eke@fastmail.com>
@ekexium ekexium requested review from you06 and joey-yez March 5, 2025 07:56
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 5, 2025
@ekexium ekexium requested a review from cfzjywxk March 5, 2025 07:56
ekexium and others added 5 commits March 5, 2025 15:57
Signed-off-by: ekexium <eke@fastmail.com>
Signed-off-by: ekexium <eke@fastmail.com>
Signed-off-by: ekexium <eke@fastmail.com>
@qiancai qiancai self-assigned this Mar 6, 2025
@qiancai qiancai added v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. translation/doing This PR’s assignee is translating this PR. labels Mar 6, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 6, 2025
Copy link

ti-chi-bot bot commented Mar 17, 2025

@joey-yez: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ekexium
Copy link
Member Author

ekexium commented Mar 17, 2025

@you06 @cfzjywxk PTAL when you have time. Thanks

pipelined-dml.md Outdated
@@ -100,6 +100,7 @@ SELECT @@tidb_last_txn_info;
## 相关配置

- 系统变量 [`tidb_dml_type`](/system-variables.md#tidb_dml_type-从-v800-版本开始引入) 用于控制是否在会话级别启用 Pipelined DML。
- 系统变量 [`tidb_pipelined_dml_resource_policy`](/system-variables.md#tidb_pipelined_dml_resource_policy) 用于控制 Pipelined DML 的资源分配策略。在 Pipelined DML 造成过大压力影响其它业务时可以考虑调整为 `conservative`。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里 “过大压力” 是否具体描述下,如 TiKV 写热点、TiCDC 等

Signed-off-by: ekexium <eke@fastmail.com>
Copy link

ti-chi-bot bot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Co-authored-by: Grace Cai <qqzczy@126.com>
@qiancai
Copy link
Collaborator

qiancai commented Mar 26, 2025

/bot-review

Copy link

✅ Code review completed, 7 comments generated.

@pingcap pingcap deleted a comment from github-actions bot Mar 26, 2025
@pingcap pingcap deleted a comment from github-actions bot Mar 26, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@pingcap pingcap deleted a comment from github-actions bot Mar 27, 2025
@pingcap pingcap deleted a comment from github-actions bot Mar 27, 2025
@pingcap pingcap deleted a comment from github-actions bot Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants