tools: refine config file for DM #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@csuzhangxc PTAL |
csuzhangxc
reviewed
Oct 21, 2019
dev/reference/tools/data-migration/configure/dm-master-configuration-file.md
Outdated
Show resolved
Hide resolved
dev/reference/tools/data-migration/configure/dm-worker-configuration-file-full.md
Outdated
Show resolved
Hide resolved
dev/reference/tools/data-migration/configure/dm-worker-configuration-file.md
Outdated
Show resolved
Hide resolved
dev/reference/tools/data-migration/configure/task-configuration-file-full.md
Outdated
Show resolved
Hide resolved
dev/reference/tools/data-migration/configure/task-configuration-file-full.md
Outdated
Show resolved
Hide resolved
dev/reference/tools/data-migration/configure/task-configuration-file.md
Outdated
Show resolved
Hide resolved
dev/reference/tools/data-migration/configure/task-configuration-file.md
Outdated
Show resolved
Hide resolved
dev/reference/tools/data-migration/configure/task-configuration-file.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Xuecheng Zhang <csuzhangxc@gmail.com>
…ration-file-full.md Co-Authored-By: Xuecheng Zhang <csuzhangxc@gmail.com>
…ration-file-full.md Co-Authored-By: Xuecheng Zhang <csuzhangxc@gmail.com>
…n-file.md Co-Authored-By: Xuecheng Zhang <csuzhangxc@gmail.com>
…n-file-full.md Co-Authored-By: Xuecheng Zhang <csuzhangxc@gmail.com>
…n-file-full.md Co-Authored-By: Xuecheng Zhang <csuzhangxc@gmail.com>
WangXiangUSTC
force-pushed
the
xiang/dm_config
branch
from
b4bd423 to
e156a53
Compare
WangXiangUSTC
force-pushed
the
xiang/dm_config
branch
from
e156a53 to
8b8c451
Compare
|
@csuzhangxc all updated, PTAL again |
…ration-file-full.md Co-Authored-By: Lilian Lee <lilin@pingcap.com>
…ration-file-full.md Co-Authored-By: Lilian Lee <lilin@pingcap.com>
…ration-file.md Co-Authored-By: Lilian Lee <lilin@pingcap.com>
…ration-file-full.md Co-Authored-By: Lilian Lee <lilin@pingcap.com>
|
@lilin90 thanks! PTAL again |
|
When the reviewer left multiple suggestions in one PR, we suggest accept them in batches. Then there will be only one commit, to keep the commits clean. @WangXiangUSTC |
ok, I will do this next time. I will update the v2.1 and v3.0 in this pr |
|
@lilin90 v2.1 and v3.0 is already updated, PTAL again |
anotherrachel
added
translation/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted?
DM has too many configurations, but user only uses part of them in normal situations. so only show basic configurations in demo/example, and split basic and full configuration for dm-worker and task.
Which version does your change affect?
only update dev, and after gets two LGTM I will update v2.1 and v3.0