Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add tags when deploy pump by ansible #1873

Merged
merged 2 commits into from
Sep 17, 2019
Merged

tools: add tags when deploy pump by ansible #1873

merged 2 commits into from
Sep 17, 2019

Conversation

WangXiangUSTC
Copy link
Contributor

What is changed, added or deleted?

add tags=pump when deploy pump, otherwise may deploy other server

Which version does your change affect?

v2.1, v3.0, dev

liubo0127
liubo0127 approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@liubo0127 liubo0127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IANTHEREAL
Copy link
Contributor

LGTM

@IANTHEREAL IANTHEREAL merged commit ffe4945 into pingcap:master Sep 17, 2019
@WangXiangUSTC WangXiangUSTC deleted the xiang/ansible-binlog branch September 17, 2019 07:35
@lilin90 lilin90 added the translation/doing This PR’s assignee is translating this PR. label Sep 17, 2019
@anotherrachel anotherrachel mentioned this pull request Sep 17, 2019
Merged
@anotherrachel anotherrachel added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liubo0127 liubo0127 liubo0127 approved these changes

Assignees

@anotherrachel anotherrachel

Labels
translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WangXiangUSTC @IANTHEREAL @liubo0127 @lilin90 @anotherrachel