Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spm fix hint issue #18534

Merged
merged 6 commits into from
Jan 7, 2025
Merged

Spm fix hint issue #18534

merged 6 commits into from
Jan 7, 2025

Conversation

songrijie
Copy link
Contributor

What is changed, added or deleted? (Required)

  • fix hint issue in one example which doesn't work.
  • remove one rewriting suggestion while it's not equivalent to original query.
  • make a few examples more comprehensible by replacing the obscure schemas with demo from "bookshop".

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions))

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@songrijie
fix hint syntax issue
6798000 
hints should follow SQL keyword to take effects.
@songrijie
removing one rewriting suggestion
82c02d4 
as it's not equivalent to original query.
@songrijie
more comprehensible examples
9140cb1 
Make a few examples more comprehensible.
@songrijie songrijie requested review from qw4990 and hfxsd September 4, 2024 11:28
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 4, 2024
elsa0520
elsa0520 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 5, 2024

@elsa0520: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2024
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Dec 20, 2024
@hfxsd hfxsd self-assigned this Dec 20, 2024
@hfxsd hfxsd added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Dec 20, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 20, 2024
hfxsd
hfxsd reviewed Dec 20, 2024
View reviewed changes
sql-plan-management.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Dec 20, 2024
View reviewed changes
sql-plan-management.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Dec 20, 2024
View reviewed changes
sql-plan-management.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Dec 20, 2024
View reviewed changes
sql-plan-management.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Dec 20, 2024
View reviewed changes
sql-plan-management.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Dec 20, 2024
View reviewed changes
sql-plan-management.md Outdated Show resolved Hide resolved
@hfxsd hfxsd mentioned this pull request Dec 20, 2024
Merged
17 tasks
qiancai
qiancai approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2024-12-20 01:43:34.95455586 +0000 UTC m=+1180405.043358401: ☑️ agreed by hfxsd.
  • 2025-01-07 03:13:37.613120997 +0000 UTC m=+236960.901952702: ☑️ agreed by qiancai.

@hfxsd
Copy link
Collaborator

hfxsd commented Jan 7, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 7, 2025
@ti-chi-bot ti-chi-bot bot merged commit 709b0f0 into master Jan 7, 2025
7 checks passed
@ti-chi-bot ti-chi-bot bot deleted the spm-fix-hint-issue branch January 7, 2025 03:36
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jan 7, 2025
@songrijie @ti-chi-bot
Spm fix hint issue (pingcap#18534)
9f4f617
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #19481.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 7, 2025
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19482.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jan 7, 2025
@songrijie @ti-chi-bot
Spm fix hint issue (pingcap#18534)
98812a1
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 7, 2025
Merged
15 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jan 7, 2025
@songrijie @ti-chi-bot
Spm fix hint issue (pingcap#18534)
d85068a
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #19483.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 7, 2025
Merged
15 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jan 7, 2025
@songrijie @ti-chi-bot
Spm fix hint issue (pingcap#18534)
fd4c157
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19484.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 7, 2025
Merged
15 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jan 7, 2025
@ti-chi-bot
Spm fix hint issue (#18534) (#19481)
bc98f3e
This was referenced Jan 7, 2025
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Jan 7, 2025
@ti-chi-bot
Spm fix hint issue (#18534) (#19482)
2b84633
ti-chi-bot bot pushed a commit that referenced this pull request Jan 7, 2025
@ti-chi-bot
Spm fix hint issue (#18534) (#19483)
2a64f5e
ti-chi-bot bot pushed a commit that referenced this pull request Jan 7, 2025
@ti-chi-bot
Spm fix hint issue (#18534) (#19484)
ba238e0
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 7, 2025
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

@elsa0520 elsa0520 elsa0520 approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@songrijie @qiancai @hfxsd @ti-chi-bot @elsa0520