Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb: remove experimental warnings for stats lock #16351

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Jan 25, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

This feature has been GAed in v7.4. But we didn't remove the warnings.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506 Rustin170506 requested a review from Oreoxmt January 25, 2024 08:03
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 25, 2024
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check

@Oreoxmt Oreoxmt self-assigned this Jan 25, 2024
@Oreoxmt Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label Jan 25, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jan 25, 2024
Copy link

ti-chi-bot bot commented Jan 25, 2024

@time-and-fate: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt requested a review from songrijie January 25, 2024 08:59
@Oreoxmt Oreoxmt added needs-cherry-pick-release-7.4 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Jan 25, 2024
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jan 26, 2024

@hi-rustin Could you please update this file:

| [锁定统计信息](/statistics.md#锁定统计信息) | E | E | E | E | N | N | N | N | N | N | N |

@songrijie Please help confirm if we need to also update the v7.4.0 release notes here:

* 增强锁定统计信息的能力 [#46351](https://github.com/pingcap/tidb/issues/46351) @[hi-rustin](https://github.com/hi-rustin)
在 v7.4.0 中,TiDB 增强了[锁定统计信息](/statistics.md#锁定统计信息)的能力。现在,锁定和解锁统计信息需要与收集统计信息 (`ANALYZE TABLE`) 相同的权限,以确保操作的安全性。此外,还新增了对特定分区的统计信息进行锁定和解锁操作的支持,提高了功能灵活性。当用户对数据库中的查询和执行计划有把握,并且不希望发生变化时,可以使用锁定统计信息来提升统计信息的稳定性。
更多信息,请参考[用户文档](/statistics.md#锁定统计信息)

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Copy link

ti-chi-bot bot commented Feb 23, 2024

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 23, 2024
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 23, 2024
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
releases/release-7.4.0.md Outdated Show resolved Hide resolved
releases/release-7.4.0.md Outdated Show resolved Hide resolved
Rustin170506 and others added 2 commits February 26, 2024 15:16
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Copy link

ti-chi-bot bot commented Feb 26, 2024

@Oreoxmt: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2024
Copy link

ti-chi-bot bot commented Feb 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-23 06:43:24.388524235 +0000 UTC m=+598693.136147346: ☑️ agreed by Oreoxmt.
  • 2024-02-26 07:30:16.618463591 +0000 UTC m=+860705.366086696: ☑️ agreed by hfxsd.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Feb 26, 2024

/approve

Copy link

ti-chi-bot bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7b4a2d5 into pingcap:master Feb 26, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #16667.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Feb 26, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16668.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Feb 26, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16669.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants