Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate docs for SHOW INDEX, SHOW KEYS infavor of SHOW INDEXES #16093

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Jan 10, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

fix #pingcap/docs#15364

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 10, 2024
@qiancai qiancai requested a review from ran-huang January 10, 2024 04:01
@qiancai qiancai added translation/from-docs This PR is translated from a PR in pingcap/docs. 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. and removed missing-translation-status This PR does not have translation status info. labels Jan 10, 2024
@ran-huang
Copy link
Contributor

Please note that PR titles should briefly summarize the content of your changes. For details, see PR Checklist.

@enkilee enkilee changed the title [Doc] fix 15364 english to chinese [Doc] fix 15364 Remove duplicate docs for SHOW INDEX, SHOW KEYS in favor of SHOW INDEXES Jan 12, 2024
@ran-huang ran-huang changed the title [Doc] fix 15364 Remove duplicate docs for SHOW INDEX, SHOW KEYS in favor of SHOW INDEXES Remove duplicate docs for SHOW INDEX, SHOW KEYS infavor of SHOW INDEXES Jan 15, 2024
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 15, 2024
@ran-huang ran-huang added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.3 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Jan 16, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 16, 2024
@ran-huang
Copy link
Contributor

The rest LGTM, but the file sql-statements/sql-statement-rename-index.md is not modified the same way as in the English PR.

@enkilee
Copy link
Contributor Author

enkilee commented Jan 23, 2024

The rest LGTM, but the file sql-statements/sql-statement-rename-index.md is not modified the same way as in the English PR.

sorry. fix it.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 24, 2024
Copy link

ti-chi-bot bot commented Jan 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-15 03:34:48.385527399 +0000 UTC m=+154129.949825104: ☑️ agreed by ran-huang.
  • 2024-01-16 03:15:20.317669276 +0000 UTC m=+239361.881966981: ✖️🔁 reset by ran-huang.
  • 2024-01-24 04:26:58.254011814 +0000 UTC m=+934859.818309504: ☑️ agreed by ran-huang.

@ran-huang ran-huang added the lgtm label Jan 24, 2024
@ran-huang
Copy link
Contributor

/approve

Copy link

ti-chi-bot bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 24, 2024
@ran-huang ran-huang merged commit fcccd66 into pingcap:master Jan 24, 2024
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jan 24, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #16277.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #16279.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jan 24, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jan 24, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #16281.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16282.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jan 24, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16283.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jan 24, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. approved contribution This PR is from a community contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.
Development

Successfully merging this pull request may close these issues.

4 participants