Skip to content

include limitation of LIKE when it works with non-binary collation #15443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 16, 2023
Merged

include limitation of LIKE when it works with non-binary collation #15443

merged 3 commits into from
Nov 16, 2023

Conversation

songrijie
Copy link
Contributor

What is changed, added or deleted? (Required)

There's a limitation when LIKE 'prefix%' works with non-binary collation. This could cause performance regression.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2023
@songrijie songrijie mentioned this pull request Nov 16, 2023
Merged
16 tasks
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 16, 2023

@time-and-fate: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ran-huang
ran-huang reviewed Nov 16, 2023
View reviewed changes
songrijie and others added 2 commits November 16, 2023 13:40
@songrijie @ran-huang
Update character-set-and-collation.md
68b526d 
Co-authored-by: Ran <huangran.alex@gmail.com>
@songrijie @ran-huang
Update character-set-gbk.md
40d0db4 
Co-authored-by: Ran <huangran.alex@gmail.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 16, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-16 05:45:40.811310388 +0000 UTC m=+4314338.398420532: ☑️ agreed by ran-huang.

@ran-huang ran-huang added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Nov 16, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 16, 2023
@ran-huang ran-huang added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.3 labels Nov 16, 2023
@ran-huang
Copy link
Contributor

/approve

@ran-huang ran-huang added the lgtm label Nov 16, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 16, 2023
@ti-chi-bot ti-chi-bot bot merged commit 65d2040 into master Nov 16, 2023
@ti-chi-bot ti-chi-bot bot deleted the unsupported-rangescan-nonbinary-collation branch November 16, 2023 05:56
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 16, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #15444.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15445.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 16, 2023
Merged
16 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 16, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #15446.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 16, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #15447.

This was referenced Nov 16, 2023
Merged
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Nov 16, 2023
@ti-chi-bot
include limitation of LIKE when it works with non-binary collation (#…
eac6168 
…15443) (#15444)
ti-chi-bot bot pushed a commit that referenced this pull request Nov 16, 2023
@ti-chi-bot
include limitation of LIKE when it works with non-binary collation (#…
d6c9553 
…15443) (#15445)
ti-chi-bot bot pushed a commit that referenced this pull request Nov 16, 2023
@ti-chi-bot
include limitation of LIKE when it works with non-binary collation (#…
4143d5a 
…15443) (#15446)
ti-chi-bot bot pushed a commit that referenced this pull request Nov 16, 2023
@ti-chi-bot
include limitation of LIKE when it works with non-binary collation (#…
8b43f96 
…15443) (#15447)
This was referenced Dec 18, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

+1 more reviewer

@ran-huang ran-huang ran-huang approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@songrijie @ran-huang @ti-chi-bot @time-and-fate