Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add collapsible topology files #15210

Merged
merged 4 commits into from
Oct 16, 2023
Merged

add collapsible topology files #15210

merged 4 commits into from
Oct 16, 2023

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

move

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang ran-huang added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.2 labels Oct 16, 2023
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 16, 2023
github-actions bot pushed a commit to ran-huang/pingcap-docs-website-scaffold that referenced this pull request Oct 16, 2023
Preview PR pingcap/docs-cn#15210 and this preview is triggered from c…
8f0d367 
…ommit pingcap/docs-cn@09c2d73
@ran-huang
Copy link
Contributor Author

/verify

@ran-huang ran-huang requested a review from qiancai October 16, 2023 05:43
@qiancai qiancai added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-16 07:40:39.475251561 +0000 UTC m=+1642837.062361691: ☑️ agreed by qiancai.

@qiancai
Copy link
Collaborator

qiancai commented Oct 16, 2023

Before this PR is merged, https://github.com/pingcap/docs-cn/pull/15215/files and its cherry-pick PRs should be merged first.

@ran-huang
Copy link
Contributor Author

/approve

@ran-huang ran-huang added the lgtm label Oct 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 16, 2023
@ran-huang ran-huang removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2023
@ti-chi-bot ti-chi-bot bot merged commit 0fd372d into pingcap:master Oct 16, 2023
3 of 4 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15236.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Oct 16, 2023
@ran-huang @ti-chi-bot
This is an automated cherry-pick of pingcap#15210
b315721 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 16, 2023
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #15237.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Oct 16, 2023
@ran-huang @ti-chi-bot
This is an automated cherry-pick of pingcap#15210
68a7956 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 16, 2023
Merged
18 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Oct 16, 2023
@ran-huang @ti-chi-bot
This is an automated cherry-pick of pingcap#15210
71729d3 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 16, 2023
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #15238.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 16, 2023
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #15239.

@ran-huang ran-huang deleted the optimize-topology-files branch October 16, 2023 11:09
ti-chi-bot bot pushed a commit that referenced this pull request Oct 16, 2023
@ti-chi-bot
add collapsible topology files (#15210) (#15236)
c71cf58
ti-chi-bot bot pushed a commit that referenced this pull request Oct 16, 2023
@ti-chi-bot
add collapsible topology files (#15210) (#15239)
cbfbf87
ti-chi-bot bot pushed a commit that referenced this pull request Oct 16, 2023
@ti-chi-bot
add collapsible topology files (#15210) (#15237)
25d25ae
ti-chi-bot bot pushed a commit that referenced this pull request Oct 16, 2023
@ti-chi-bot
add collapsible topology files (#15210) (#15238)
ca5dbb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

Assignees
No one assigned
Labels
approved lgtm missing-translation-status This PR does not have translation status info. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ran-huang @qiancai @ti-chi-bot