Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: update topic expression description #15115

Merged
merged 3 commits into from
Oct 8, 2023

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Sep 27, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 27, 2023

@nongfushanquan: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd self-assigned this Sep 28, 2023
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. v7.4 This PR/issue applies to TiDB v7.4. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. and removed missing-translation-status This PR does not have translation status info. labels Sep 28, 2023
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
@hfxsd hfxsd changed the title cdc: update topic expression description. cdc: update topic expression description Oct 7, 2023
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 7, 2023
@hfxsd hfxsd requested a review from qiancai October 7, 2023 12:36
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 7, 2023
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-07 12:49:28.904039964 +0000 UTC m=+883766.491150109: ☑️ agreed by hfxsd.
  • 2023-10-08 06:08:26.517759929 +0000 UTC m=+946104.104870074: ☑️ agreed by qiancai.

Co-authored-by: Grace Cai <qqzczy@126.com>
@hfxsd
Copy link
Collaborator

hfxsd commented Oct 8, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 8, 2023
@ti-chi-bot ti-chi-bot bot merged commit dbed07d into pingcap:master Oct 8, 2023
@qiancai qiancai added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 4, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #15992.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15998.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. contribution This PR is from a community contributor. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.4 This PR/issue applies to TiDB v7.4.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants