Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add document about 0900 collations and variables #15042

Merged
merged 3 commits into from
Sep 27, 2023
Merged

add document about 0900 collations and variables #15042

merged 3 commits into from
Sep 27, 2023

Conversation

YangKeao
Copy link
Member

What is changed, added or deleted? (Required)

  1. Modify the original document about charset and collations. We have added two collations: "utf8mb4_0900_bin" and "utf8mb4_0900_ai_ci" and they are compatible with MySQL.
  2. Add a new variable "default_collation_for_utf8mb4"

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2023
@YangKeao
add document about 0900 collations and variables
deadc41 
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
zimulala
zimulala approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 15, 2023
@Oreoxmt Oreoxmt self-assigned this Sep 15, 2023
@Oreoxmt Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label Sep 15, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 15, 2023
@Oreoxmt Oreoxmt added v7.4 This PR/issue applies to TiDB v7.4. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Sep 15, 2023
@YangKeao YangKeao mentioned this pull request Sep 15, 2023
Merged
17 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 18, 2023
Oreoxmt
Oreoxmt reviewed Sep 18, 2023
View reviewed changes
character-set-and-collation.md Outdated Show resolved Hide resolved
character-set-and-collation.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@YangKeao
fix according to comments
36a927a 
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-15 03:45:27.939075655 +0000 UTC m=+229893.906663704: ☑️ agreed by zimulala.
  • 2023-09-18 05:55:52.510017431 +0000 UTC m=+496918.477605495: ☑️ agreed by Oreoxmt.

@Oreoxmt Oreoxmt requested a review from ran-huang September 18, 2023 05:56
ran-huang
ran-huang approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Sep 27, 2023

/verify

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Sep 27, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 27, 2023
@ti-chi-bot ti-chi-bot bot merged commit 59bc2bc into pingcap:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@ran-huang ran-huang ran-huang approved these changes

@zimulala zimulala zimulala approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.4 This PR/issue applies to TiDB v7.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YangKeao @Oreoxmt @zimulala @ran-huang