Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add table style plan on tidb dashboard #15041

Merged
merged 10 commits into from
Sep 28, 2023
Merged

add table style plan on tidb dashboard #15041

merged 10 commits into from
Sep 28, 2023

Conversation

lilyjazz
Copy link
Member

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 15, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 15, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2023
@lilyjazz
Copy link
Member Author

@Oreoxmt @baurine PTAL

@Oreoxmt Oreoxmt self-requested a review September 15, 2023 02:04
@Oreoxmt Oreoxmt self-assigned this Sep 15, 2023
@Oreoxmt Oreoxmt added translation/doing This PR’s assignee is translating this PR. v7.4 This PR/issue applies to TiDB v7.4. labels Sep 15, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 15, 2023
Oreoxmt
Oreoxmt reviewed Sep 15, 2023
View reviewed changes
@lilyjazz @Oreoxmt
Apply suggestions from code review
7562689 
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 15, 2023
@Oreoxmt Oreoxmt requested a review from ran-huang September 15, 2023 03:09
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 18, 2023

@baurine: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt added the area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. label Sep 18, 2023
@Oreoxmt Oreoxmt mentioned this pull request Sep 18, 2023
Merged
17 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 18, 2023
Oreoxmt and others added 3 commits September 21, 2023 16:04
@Oreoxmt
make ci happy
d23ef3a 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@lilyjazz
Merge pull request #1 from Oreoxmt/review-table-style
9a33eb8 
make ci happy
@Oreoxmt
make ci happy
dd43c1c 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt Oreoxmt requested a review from ran-huang September 27, 2023 04:38
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-15 03:09:05.023567533 +0000 UTC m=+227710.991155584: ☑️ agreed by Oreoxmt.
  • 2023-09-28 07:49:22.181504332 +0000 UTC m=+88159.768614476: ☑️ agreed by ran-huang.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Sep 28, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 28, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8f69d99 into pingcap:master Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@baurine baurine baurine approved these changes

@ran-huang ran-huang ran-huang approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.4 This PR/issue applies to TiDB v7.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilyjazz @Oreoxmt @baurine @ran-huang