Skip to content

Conversation

Icemap
Copy link
Member

@Icemap Icemap commented Aug 25, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Icemap Icemap added translation/doing This PR’s assignee is translating this PR. area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.2 labels Aug 25, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 25, 2023
@Icemap Icemap marked this pull request as ready for review August 28, 2023 03:52
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2023
@Icemap
Copy link
Member Author

Icemap commented Aug 28, 2023

/cc @Oreoxmt @sykp241095 @Mini256 @shizn

@ti-chi-bot ti-chi-bot bot requested review from Oreoxmt, sykp241095 and Mini256 August 28, 2023 03:53
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 28, 2023

@Icemap: GitHub didn't allow me to request PR reviews from the following users: shizn.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Oreoxmt @sykp241095 @Mini256 @shizn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

title: TiDB 和 GORM 的简单 CRUD 应用程序
summary: 给出一个 TiDB 和 GORM 的简单 CRUD 应用程序示例
title: 使用 GORM 连接到 TiDB
summary: 本文描述了 TiDB 和 GORM 的连接步骤,并给出了简单示例代码片段
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
summary: 本文描述了 TiDB 和 GORM 的连接步骤,并给出了简单示例代码片段
summary: 本文描述了 TiDB 和 GORM 的连接步骤,并给出了简单示例代码片段

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

水一个_

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样可能水不进去,可以提两个 commits,一个改过去,一个改回来 XD

Copy link
Member

@sykp241095 sykp241095 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 28, 2023

@sykp241095: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

```golang
openDB("mysql", func(db *sql.DB) {
insertSQL = "INSERT INTO player (id, coins, goods) VALUES (?, ?, ?)"
_, err := db.Exec(insertSQL, "id", 1, 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

第一列 是 "id"?, 这个 player 表好像没有看到建表?

id 还是用数字好一些?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是 sql-driver repository 的代码片段。为了尽量精简文档,建表过程都是没包含在文档内的。

Co-authored-by: sykp241095 <sykp241095@gmail.com>
Icemap and others added 2 commits August 30, 2023 11:09
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 4, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-04 09:37:54.211087855 +0000 UTC m=+2351838.760103826: ☑️ agreed by Oreoxmt.
  • 2023-09-04 10:03:47.311140944 +0000 UTC m=+2353391.860156916: ☑️ agreed by wd0517.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Sep 4, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 4, 2023
@ti-chi-bot ti-chi-bot bot merged commit 1bab6e9 into pingcap:master Sep 4, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14965.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 4, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #14966.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 4, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #14967.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 4, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14968.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 4, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 4, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Sep 4, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Sep 4, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/develop This PR relates to the area of TiDB App development. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants