Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly mention mysql 8.0 in MySQL compatibility #14196

Merged
merged 5 commits into from
Jun 26, 2023

Conversation

songrijie
Copy link
Contributor

@songrijie songrijie commented Jun 12, 2023

  1. mysql 8.0 is mentioned explicitly
  2. include the description of a few unsupported features from Mysql 8.0

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

1. mysql 8.0 is mentioned explicitly
2. include the description of a few unsupported features from Mysql 8.0
@songrijie songrijie requested a review from Oreoxmt June 12, 2023 03:19
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 12, 2023
@songrijie songrijie requested review from hfxsd and bb7133 June 12, 2023 03:19
mysql-compatibility.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 12, 2023
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.2 This PR/issue applies to TiDB v7.2. and removed missing-translation-status This PR does not have translation status info. labels Jun 12, 2023
@hfxsd hfxsd self-assigned this Jun 12, 2023
@hfxsd hfxsd requested review from hfxsd and ran-huang and removed request for Oreoxmt June 12, 2023 06:05
@songrijie songrijie requested a review from easonn7 June 12, 2023 13:41
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 14, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-12 04:20:44.709684186 +0000 UTC m=+126194.164445489: ☑️ agreed by hfxsd.
  • 2023-06-14 06:33:18.691372947 +0000 UTC m=+153795.105977026: ☑️ agreed by ran-huang.

@qiancai qiancai added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2023
@hfxsd hfxsd removed the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Jun 21, 2023
mysql-compatibility.md Outdated Show resolved Hide resolved
@hfxsd hfxsd removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2023
@hfxsd
Copy link
Collaborator

hfxsd commented Jun 26, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 26, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8d1c34e into master Jun 26, 2023
@ti-chi-bot ti-chi-bot bot deleted the mysql-compatibility-include-mysql8 branch June 26, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.2 This PR/issue applies to TiDB v7.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants