Skip to content

br: update pitr docs #11184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 8, 2022
Merged

br: update pitr docs #11184

merged 8 commits into from
Sep 8, 2022

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Sep 2, 2022 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Leavrth
update pitr docs
f039100 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
add configuration
63e7723 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@shichun-0415 shichun-0415 self-requested a review September 2, 2022 08:13
@shichun-0415 shichun-0415 self-assigned this Sep 2, 2022
@shichun-0415 shichun-0415 added translation/doing This PR’s assignee is translating this PR. area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). v6.3 This PR/issue applies to TiDB v6.3. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Sep 2, 2022
shichun-0415
shichun-0415 reviewed Sep 6, 2022
View reviewed changes
@Leavrth
commit some suggestions
790973e 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 6, 2022
shichun-0415
shichun-0415 reviewed Sep 6, 2022
View reviewed changes
shichun-0415
shichun-0415 approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 6, 2022
IANTHEREAL
IANTHEREAL requested changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@IANTHEREAL IANTHEREAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please confirm the new added parameters

IANTHEREAL
IANTHEREAL requested changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@IANTHEREAL IANTHEREAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please confirm the new added parameters

@Leavrth
commit some suggestions
2d4fe5a 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
merge configuration parameter
157e799 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 8, 2022
@Leavrth
fix typos
900723c 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
IANTHEREAL
IANTHEREAL reviewed Sep 8, 2022
View reviewed changes
@IANTHEREAL
Copy link
Contributor

Rest LGTM

@Leavrth
commit some suggestions
cffd4c2 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
shichun-0415
shichun-0415 reviewed Sep 8, 2022
View reviewed changes
@Leavrth
commit some suggestions
2a3e1fd 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth Leavrth requested a review from IANTHEREAL September 8, 2022 03:45
@shichun-0415
Copy link
Contributor

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 8, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2a3e1fd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 8, 2022
@ti-chi-bot ti-chi-bot merged commit 2d46bec into pingcap:master Sep 8, 2022
@shichun-0415 shichun-0415 mentioned this pull request Sep 13, 2022
Merged
13 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 13, 2022
@Leavrth Leavrth deleted the pitr_less_files branch November 21, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

+1 more reviewer

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@shichun-0415 shichun-0415

Labels
area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.3 This PR/issue applies to TiDB v6.3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Leavrth @ti-chi-bot @IANTHEREAL @shichun-0415