Skip to content

Add tidb super read only#10801

Merged
ti-chi-bot merged 9 commits into
pingcap:masterfrom
qiancai:add_tidb_super_read_only
Sep 21, 2022
Merged

Add tidb super read only#10801
ti-chi-bot merged 9 commits into
pingcap:masterfrom
qiancai:add_tidb_super_read_only

Conversation

@qiancai

@qiancai qiancai commented Aug 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs This PR is translated from a PR in pingcap/docs. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. labels Aug 6, 2022
@ti-chi-bot

ti-chi-bot commented Aug 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SunRunAway
  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn August 6, 2022 04:58
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 6, 2022
@qiancai qiancai added needs-cherry-pick-release-5.3 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Aug 6, 2022
@qiancai qiancai requested a review from SunRunAway August 6, 2022 05:13
SunRunAway
SunRunAway reviewed Aug 6, 2022
View reviewed changes
Comment thread system-variables.md Outdated
SunRunAway
SunRunAway reviewed Aug 6, 2022
View reviewed changes
Comment thread system-variables.md Outdated
qiancai and others added 2 commits August 6, 2022 19:00
@qiancai @SunRunAway
Update system-variables.md
b3ff6ab 
Co-authored-by: Feng Liyuan <darktemplar.f@gmail.com>
@qiancai
Update system-variables.md
dbf2f57
TomShawn
TomShawn approved these changes Aug 18, 2022
View reviewed changes

@TomShawn TomShawn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 18, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2022
qiancai and others added 2 commits September 21, 2022 11:20
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2022
@qiancai

qiancai commented Sep 21, 2022

Copy link
Copy Markdown
Collaborator Author

@SunRunAway All the comments are resolved now. If no further comments, please approve this PR.

@qiancai

qiancai commented Sep 21, 2022

Copy link
Copy Markdown
Collaborator Author

/verify

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 21, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 21, 2022
TomShawn
TomShawn reviewed Sep 21, 2022
View reviewed changes
Comment thread system-variables.md Outdated
TomShawn
TomShawn approved these changes Sep 21, 2022
View reviewed changes

@TomShawn TomShawn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiancai @TomShawn
Update system-variables.md
c4e923e 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@qiancai

qiancai commented Sep 21, 2022

Copy link
Copy Markdown
Collaborator Author

/merge

@ti-chi-bot

ti-chi-bot commented Sep 21, 2022

Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: c4e923e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2022
@ti-chi-bot ti-chi-bot merged commit 72065f7 into pingcap:master Sep 21, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 21, 2022
Merged
13 tasks
@ti-chi-bot

ti-chi-bot commented Sep 21, 2022

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #11363.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 21, 2022
@qiancai @ti-chi-bot
This is an automated cherry-pick of pingcap#10801
eb652e8 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 21, 2022
Merged
13 tasks
@ti-chi-bot

ti-chi-bot commented Sep 21, 2022

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #11364.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 21, 2022
@qiancai @ti-chi-bot
This is an automated cherry-pick of pingcap#10801
6d66fc8 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 21, 2022
Merged
13 tasks
@ti-chi-bot

ti-chi-bot commented Sep 21, 2022

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #11365.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 21, 2022
Merged
13 tasks
@ti-chi-bot

ti-chi-bot commented Sep 21, 2022

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #11366.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 21, 2022
@qiancai @ti-chi-bot
Add tidb super read only (pingcap#10801)
201ce06
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 21, 2022
Merged
13 tasks
@ti-chi-bot

ti-chi-bot commented Sep 21, 2022

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #11367.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 21, 2022
@qiancai @ti-chi-bot
Add tidb super read only (pingcap#10801)
3770ac1
ti-chi-bot added a commit that referenced this pull request Sep 21, 2022
@ti-chi-bot
Add tidb super read only (#10801) (#11367)
0f6d760
ti-chi-bot added a commit that referenced this pull request Sep 21, 2022
@ti-chi-bot
Add tidb super read only (#10801) (#11366)
29a32fc
ti-chi-bot added a commit that referenced this pull request Sep 21, 2022
@ti-chi-bot
Add tidb super read only (#10801) (#11365)
79ae583
ti-chi-bot added a commit that referenced this pull request Sep 21, 2022
@ti-chi-bot
Add tidb super read only (#10801) (#11364)
c7c8736
ti-chi-bot added a commit that referenced this pull request Sep 21, 2022
@ti-chi-bot
Add tidb super read only (#10801) (#11363)
8c68f06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@SunRunAway SunRunAway SunRunAway approved these changes
@TomShawn TomShawn TomShawn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qiancai @ti-chi-bot @SunRunAway @TomShawn