Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

cherrypick for v1.0.7 #1793

Open
wants to merge 4 commits into
base: release-1.0
Choose a base branch
from
Open

cherrypick for v1.0.7 #1793

wants to merge 4 commits into from

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Jun 21, 2021 •
edited
Loading

What problem does this PR solve?

  • update DM version for DM-Ansible
  • fix checkpoint bug
  • update release note

@GMHDBJD GMHDBJD changed the title update DM version for DM-Ansible cherrypick for v1.0.7 Jun 21, 2021
@ti-chi-bot ti-chi-bot added size/L and removed size/XS labels Jun 21, 2021
@ti-chi-bot
Copy link
Member

@Ehco1996: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716
Copy link
Collaborator

close now?

@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Jun 23, 2021

Won't we cherrypick these PRs to release-1.0?

lance6716
lance6716 approved these changes Jun 23, 2021
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope there's no 1.0.8 in future 😂 And if we want to merge this PR, lots of CI work is needed

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Jun 23, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jun 23, 2021
lichunzhu
lichunzhu approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu
Copy link
Contributor

/run-all-tests

@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ebcc58c

@ti-chi-bot
Copy link
Member

@GMHDBJD: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716
Copy link
Collaborator

/hold

waiting upgrade CI (or never)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@glorv glorv glorv approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

@Ehco1996 Ehco1996 Ehco1996 approved these changes

Assignees
No one assigned
Labels
do-not-merge/hold size/L status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge status/Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GMHDBJD @ti-chi-bot @lance6716 @lichunzhu @glorv @Ehco1996