Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update member list for sig/ddl, promote xiongjiwei to reviewer #324

Merged
merged 2 commits into from
Oct 25, 2020
Merged

update member list for sig/ddl, promote xiongjiwei to reviewer #324

merged 2 commits into from
Oct 25, 2020

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Oct 23, 2020

As stated:

@xiongjiwei has 20+ PRs merged in TiDB repo related to DDL and charset, in which:

wjhuang2016
wjhuang2016 reviewed Oct 23, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tangenta
tangenta approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AndreMouche AndreMouche merged commit b621b21 into pingcap:master Oct 25, 2020
@bb7133 bb7133 deleted the bb7133/update_ddl_sig branch October 27, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bb7133 @CLAassistant @wjhuang2016 @tangenta @AndreMouche