Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

backup: allow backup tolerate minor TiKV failure #997

Merged
merged 14 commits into from
Apr 15, 2021
Merged

backup: allow backup tolerate minor TiKV failure #997

merged 14 commits into from
Apr 15, 2021

Conversation

YuJuncen
Copy link
Collaborator

What problem does this PR solve?

fixed #980

What is changed and how it works?

ignore all ‘failed to connect to store’ errors during backup.

Check List

Tests

  • Integration test

Release Note

  • BR now can tolerate minor TiKV disconnection.

@ti-chi-bot ti-chi-bot requested a review from kennytm April 12, 2021 08:05
@YuJuncen
Copy link
Collaborator Author

After this merged, I think we need to add br_serv_outage to slow case, or strip some cases...

image

@3pointer 3pointer added this to the v5.0.1 milestone Apr 13, 2021
@3pointer
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Apr 14, 2021
kennytm
kennytm reviewed Apr 14, 2021
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tests/br_serv_outage/run.sh Outdated Show resolved Hide resolved
pkg/backup/push.go
@@ -51,6 +53,11 @@ func (push *pushDown) pushBackup(

// Push down backup tasks to all tikv instances.
res := rtree.NewRangeTree()
failpoint.Inject("noop-backup", func(_ failpoint.Value) {
log.Warn("skipping normal backup, jump to fine-grained backup, meow :3", logutil.Key("start-key", req.StartKey), logutil.Key("end-key", req.EndKey))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😼

pkg/backup/client.go Outdated Show resolved Hide resolved
@YuJuncen @kennytm
Apply suggestions from code review
90ee883 
Co-authored-by: kennytm <kennytm@gmail.com>
@kennytm
Copy link
Collaborator

kennytm commented Apr 15, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Apr 15, 2021
@3pointer
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0106164

@YuJuncen
Copy link
Collaborator Author

/run-integration-tests

1 similar comment
@YuJuncen
Copy link
Collaborator Author

/run-integration-tests

@YuJuncen
Copy link
Collaborator Author

/run-integration-tests

1 similar comment
@YuJuncen
Copy link
Collaborator Author

/run-integration-tests

@ti-chi-bot ti-chi-bot merged commit db863d5 into pingcap:master Apr 15, 2021
ti-srebot pushed a commit to ti-srebot/br that referenced this pull request Apr 15, 2021
@YuJuncen @ti-srebot
cherry pick pingcap#997 to release-5.0
9334730 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 15, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #1019

ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2021
@ti-srebot
backup: allow backup tolerate minor TiKV failure (#997) (#1019)
264059b
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
ti-chi-bot pushed a commit that referenced this pull request May 13, 2021
@ti-srebot
backup: allow backup tolerate minor TiKV failure (#997) (#1019) (#1062)
7f61247
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm left review comments

@3pointer 3pointer Awaiting requested review from 3pointer

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
component/backup needs-cherry-pick-release-5.0 size/XL status/can-merge status/LGT2 LGTM2
Projects
None yet
Milestone
v5.0.1
Development

Successfully merging this pull request may close these issues.

BR should tolerate a small amount of tikv crash
5 participants
@YuJuncen @3pointer @kennytm @ti-chi-bot @ti-srebot