Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

lightning: always enable autocommit in db connection (#1114) #1124

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1114

What problem does this PR solve?

close #1104

What is changed and how it works?

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the bug that lightning tidb backend cannot load any data when autocommit is disabled.

@3pointer
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label May 20, 2021
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels May 20, 2021
@glorv
Copy link
Collaborator

glorv commented May 20, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 19d43f6

@lonng
Copy link
Contributor

lonng commented May 20, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 142703a into pingcap:release-4.0 May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants