Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Some error logs are confusing #403

Closed
@amyangfei

Description

@amyangfei

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

br/pkg/backup/push.go

Lines 96 to 103 in 8ffad37

errPb := resp.GetError()
switch v := errPb.Detail.(type) {
case *backup.Error_KvError:
log.Error("backup occur kv error", zap.Reflect("error", v))
case *backup.Error_RegionError:
log.Error("backup occur region error",
zap.Reflect("error", v))

Is the error backup.Error_KvError and backup.Error_RegionError retryable? If so, error log may be confused.

  1. What did you expect to see?

  2. What did you see instead?

  3. What version of BR and TiDB/TiKV/PD are you using?

Metadata

Metadata

Assignees

No one assigned

    Labels

    status/discussionThis is waiting for / still in discussiontype/bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions