use hash index instead of bloom filter #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coocood
reviewed
Apr 12, 2019
| // Add key to bloom filter. | ||
| if len(key) > 0 { | ||
| y.Assert(len(key) > 0) | ||
| if b.enableHashIndex { |
There was a problem hiding this comment.
Need enable by default and remove the option?
|
I also tried this improvement a few months ago, but at the time I found that performance was degraded during the benchmark. Maybe due to hash index has a much higher false positive rate (hash collision) which slows down the lookup in the higher levels? I'm considering about disabling bloom filter only for the last level as Monkey proposed? |
|
@bobotu if some of the Get requests tries to find a non-exist key, enable bloom filter still have benefits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash index is much better than bloom filter, much more efficiency.
I also add some comments to describe the SST format.