fix windows compile error for directio pkg #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YangKeao
force-pushed
the
fix-windows-build
branch
from
0350f6f to
44aa18b
Compare
xiongjiwei
approved these changes
Jan 3, 2023
YangKeao
force-pushed
the
fix-windows-build
branch
from
44aa18b to
3c91c47
Compare
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
YangKeao
force-pushed
the
fix-windows-build
branch
from
3c91c47 to
bdc7fab
Compare
coocood
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YangKeao yangkeao@chunibyo.icu
The directio pkg uses
unix.EINVAL, which doesn't exit in windows. To support windows, I'd add a compilation flag and use the original directio directly.I also find that the errors returned in the darwin and openbsd is different with Linux. In Linux, it returns the return the EINVAL (directly by the system call). For darwin, it's a software defined "Failed to set F_NOCACHE: %s". The windows seems to be more complicated. As I don't have a Mac OS / Windows device, I left it here to return the result directly.
Actually, I'm not sure whether there are file systems like tmpfs which don't support direct io in Mac OS and other systems.