compaction skip non-overlapping bottom tables #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If all top tables doesn’t contain a bottom table’s range, we can skip the bottom table in the compaction. Reduces write amplification.
coocood
changed the title
coocood
changed the title
coocood
changed the title
coocood
force-pushed
the
skip-bottom-tables
branch
from
af9267e to
5a873e0
Compare
ngaut
reviewed
Sep 2, 2019
| tables = append(tables, newTables...) | ||
| tables = append(tables, skippedTbls...) | ||
| tables = append(tables, s.tables[right:]...) | ||
| sortTables(tables) |
There was a problem hiding this comment.
Could you keep assertTablesOrder to make sure assertion is always true?
ngaut
reviewed
Sep 2, 2019
| if iter.Valid() && y.CompareKeysWithVer(iter.Key(), t.Biggest()) <= 0 { | ||
| cd.bot = append(cd.bot, t) | ||
| added = true | ||
| break |
There was a problem hiding this comment.
return here and remove the the added boolean flag check.
There was a problem hiding this comment.
Only one bottom table will be added if we return here.
We need to add more bottom tables.
coocood
changed the title
|
@ngaut PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all top tables doesn’t contain a bottom table’s range, we can skip the bottom table in the compaction.
Reduces write amplification.