Fix issue with numpy long not being supported in cython 3.1.0 #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the latest version of CRISPresso2 from python fails because the project.toml uses Cython 3.1.0 that no longer supports the
longtype. See: #535CRITICAL @ Fri, 16 May 2025 17:02:58 (0.5% done): Traceback (most recent call last): File "/usr/local/lib/python3.12/site-packages/CRISPResso2/CRISPRessoCORE.py", line 1429, in main aln_matrix = CRISPResso2Align.read_matrix(aln_matrix_loc) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "CRISPResso2/CRISPResso2Align.pyx", line 43, in CRISPResso2.CRISPResso2Align.read_matrix File "CRISPResso2/CRISPResso2Align.pyx", line 51, in CRISPResso2.CRISPResso2Align.read_matrix NameError: name 'long' is not defined CRITICAL @ Fri, 16 May 2025 17:02:58 (0.5% done): Unexpected error, please check your input. ERROR: name 'long' is not definedThis PR sticks the version of the project.toml to built it with a previous cython version.
Solution found by @rohan-mammothbio