Skip to content

Implement deletion protection #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 30, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into emily/regenerate-code
  • Loading branch information
ericapywang committed Jul 25, 2024
commit e9c20a9dda8ded341f330c04a22ea9abbd5c104b
4 changes: 2 additions & 2 deletions openapi/src/apis/manage_indexes_api.rs
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ pub async fn configure_index(configuration: &configuration::Configuration, index
local_var_req_builder = local_var_req_builder.header("Api-Key", local_var_value);
};
local_var_req_builder = local_var_req_builder.json(&configure_index_request);
local_var_req_builder = local_var_req_builder.header("X-Pinecone-API-Version", "2024-07"); // DELETE THIS LINE
// local_var_req_builder = local_var_req_builder.header("X-Pinecone-API-Version", "2024-07"); // DELETE THIS LINE

let local_var_req = local_var_req_builder.build()?;
let local_var_resp = local_var_client.execute(local_var_req).await?;
Expand Down Expand Up @@ -211,7 +211,7 @@ pub async fn create_index(configuration: &configuration::Configuration, create_i
local_var_req_builder = local_var_req_builder.header("Api-Key", local_var_value);
};
local_var_req_builder = local_var_req_builder.json(&create_index_request);
local_var_req_builder = local_var_req_builder.header("X-Pinecone-API-Version", "2024-07"); // DELETE THIS LINE
// local_var_req_builder = local_var_req_builder.header("X-Pinecone-API-Version", "2024-07"); // DELETE THIS LINE

let local_var_req = local_var_req_builder.build()?;
let local_var_resp = local_var_client.execute(local_var_req).await?;
Expand Down
7 changes: 2 additions & 5 deletions pinecone_sdk/tests/integration_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,7 @@ async fn test_fetch_vectors() -> Result<(), PineconeError> {
std::thread::sleep(std::time::Duration::from_secs(5));

let fetch_response = index
.fetch(&["1".to_string(), "2".to_string()], namespace)
.fetch(&["1", "2"], namespace)
.await
.expect("Failed to fetch vectors");

Expand Down Expand Up @@ -1127,10 +1127,7 @@ async fn test_fetch_no_match() -> Result<(), PineconeError> {
.expect("Failed to target index");

let fetch_response = index
.fetch(
&["invalid-id1".to_string(), "invalid-id2".to_string()],
&Default::default(),
)
.fetch(&["invalid-id1", "invalid-id2"], &Default::default())
.await
.expect("Failed to fetch vectors");

Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.