Implement asyncio for db control plane#442
Merged
jhamon merged 7 commits intorelease-candidate/2025-01from Jan 31, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Previous work implemented asyncio for the db data plane, and now we want to roll out a similar approach for the db control plane and inference as well.
Solution
Pineconeand move it to a request factoryPineconeAsynciousing the request factory to keep most of the method-specific logic the same.Usage
The async version of the client has some async setup/teardown related to the underlying aiohttp library being used. You can either use the
async withsyntax to have the async context automatically managed for you. Or, if you prefer, you can take the responsibility to close the async context yourself by usingclose().Context management option 1: Using
async withContext management option 2: Manually
close()Sparse index example
Type of Change