Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on_delete is not explicitly set for ForeignKeys in models.py #255

Closed
RevolutionTech opened this issue Apr 11, 2016 · 0 comments
Closed

on_delete is not explicitly set for ForeignKeys in models.py #255

RevolutionTech opened this issue Apr 11, 2016 · 0 comments
Labels
enhancement
Milestone
post-16.07

Comments

@RevolutionTech
Copy link

ForeignKeys defined in stripe/models.py do not explicitly define on_delete behaviour. This will become required in Django 2.0 and in the meantime throws django.utils.deprecation.RemovedInDjango20Warning in Django 1.9.

You can set these to the current default explicitly by adding on_delete=models.CASCADE to each ForeignKey.
@jtauber jtauber modified the milestone: post-16.07 Jul 28, 2016
felixxm added a commit to felixxm/pinax-stripe that referenced this issue Oct 27, 2016
@felixxm
Fixed pinax#255 -- on_delete will be a required arg for ForeignKey in…
e1abb51 
… Django 2.0.
paltman added a commit that referenced this issue Dec 21, 2016
@paltman
Merge pull request #288 from felixxm/issue-255
ec14b69 
Fixed #255 -- on_delete will be a required arg for ForeignKey/OneToOneField in Django 2.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
post-16.07
Development

No branches or pull requests
3 participants
@jtauber @RevolutionTech @ossanna16