Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template rendering for compatibility with Django 1.10+ #70

Merged
merged 7 commits into from
Nov 4, 2016
Merged

Fix template rendering for compatibility with Django 1.10+ #70

merged 7 commits into from
Nov 4, 2016

Conversation

jacobwegner
Copy link

  • Update test matrix for Django 1.8, 1.9, 1.10 and master
  • Fix template deprecations in 1.8, 1.9 and incompatibility in Django 1.10 and up
  • Note that the template fix is backwards incompatible; any plain text templates must now invoke autoescape off explicitly
  • Backfill changelog for prior releases

@jacobwegner
update test matrix
81e4d53
@jacobwegner
pass dict to render_to_string (BI change)
9878504 
In Django 1.10+, render_to_string no longer accepts a context instance
as an argument.

To maintain existing behavior (templates ending in .txt aren't auto-escaped), developers
should explicitly wrap their short.txt and full.txt templates in an autoescape block.

https://docs.djangoproject.com/en/1.9/ref/templates/language/#for-template-blocks
@jacobwegner
set autoescape off explicitly in default plain text templates
4a947ff
@jacobwegner
backfill changelog
74ffd9f
@jacobwegner
note backwards incompatible change
e50f1cf
@jacobwegner
clarify the user's notices must be autoescaped
eb7caae
@jacobwegner
fix message variable name in context
28dd70c
@jacobwegner
Copy link
Author

resolves #68

@jacobwegner jacobwegner merged commit 39899c2 into master Nov 4, 2016
@jacobwegner jacobwegner deleted the fix-template-deprecations branch November 4, 2016 17:31
@coveralls
Copy link

coveralls commented Nov 4, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 71.811% when pulling 28dd70c on fix-template-deprecations into 085f6da on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 71.811% when pulling 28dd70c on fix-template-deprecations into 085f6da on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobwegner @coveralls