Skip to content

Validate email address case insensitive uniqueness at the model level #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 24, 2021

Conversation

jpotterm
Copy link
Contributor

EmailAddress.email is currently treated as case insensitive unique on login, but that is only enforced in the signup form. In order to enforce that in the admin and when someone programmatically adds an email address it needs to enforce it at the model level. That's what this pull request does.

@coveralls
Copy link

coveralls commented Sep 15, 2016

Coverage Status

Coverage decreased (-0.2%) to 69.151% when pulling c82b67e on jpotterm:email_validate_unique_case_insensitive into 1a5cab5 on pinax:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 69.151% when pulling c82b67e on jpotterm:email_validate_unique_case_insensitive into 1a5cab5 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 69.151% when pulling c82b67e on jpotterm:email_validate_unique_case_insensitive into 1a5cab5 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 69.151% when pulling c82b67e on jpotterm:email_validate_unique_case_insensitive into 1a5cab5 on pinax:master.

Copy link
Member

@brosner brosner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of this change, but I'd like for this to get some test coverage before I merge.

@jpotterm
Copy link
Contributor Author

@brosner I've added a test case for this.

@paltman paltman merged commit 75dc90c into pinax:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants