Skip to content

Commit

Permalink
ARROW-8511: [Release] In verify-release-candidate.bat, exit when CMak…
Browse files Browse the repository at this point in the history
…e build fails, use Unity build

The unity build makes things faster, but it also hides the error reported in ARROW-8510. This at least allows the release verification to pass for 0.17.0

Closes #6978 from wesm/ARROW-8511

Authored-by: Wes McKinney <wesm+git@apache.org>
Signed-off-by: Wes McKinney <wesm+git@apache.org>
  • Loading branch information
wesm authored and kszucs committed Apr 20, 2020
1 parent 0b7ddb1 commit 8d8a532
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion dev/release/verify-release-candidate.bat
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ cmake -G "%GENERATOR%" ^
-DARROW_BUILD_TESTS=ON ^
-DGTest_SOURCE=BUNDLED ^
-DCMAKE_BUILD_TYPE=%CONFIGURATION% ^
-DCMAKE_UNITY_BUILD=ON ^
-DARROW_CXXFLAGS="/MP" ^
-DARROW_WITH_BZ2=ON ^
-DARROW_WITH_ZLIB=ON ^
Expand All @@ -94,7 +95,7 @@ cmake -G "%GENERATOR%" ^
-DARROW_PARQUET=ON ^
.. || exit /B

cmake --build . --target INSTALL --config Release
cmake --build . --target INSTALL --config Release || exit /B 1

@rem NOTE(wesm): Building googletest is flaky for me with ninja. Building it
@rem first fixes the problem
Expand Down

0 comments on commit 8d8a532

Please sign in to comment.