Badger 2040W: Custom WiFi status handler for #30 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exussum12
suggested changes
Jun 30, 2023
| from network_manager import NetworkManager | ||
| import WIFI_CONFIG | ||
| import uasyncio | ||
| import gc | ||
|
|
||
| status_handler = args.get("status_handler", self.status_handler) | ||
|
|
||
| if WIFI_CONFIG.COUNTRY == "": | ||
| raise RuntimeError("You must populate WIFI_CONFIG.py for networking.") | ||
| self.display.set_update_speed(2) |
There was a problem hiding this comment.
It would be good to remove this too, really it should have been in the function above. Its a strange side effect, connecting to wifi changes the speed the display updates at
There was a problem hiding this comment.
Agreed, I'll move it into the handler.
Gadgetoid
force-pushed
the
patch-wifi-connect
branch
from
f273f7e
to
9b98435
Compare
exussum12
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.