[Improvement] Data Objects - Custom Layouts #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayouts' into 658-task-data-objects---custom-layouts
…ayouts' into 658-task-data-objects---custom-layouts # Conflicts: # src/Class/Service/CustomLayoutService.php
…ayouts' into 658-task-data-objects---custom-layouts
…ayouts' into 658-task-data-objects---custom-layouts
…ayouts' into 658-task-data-objects---custom-layouts
lukmzig
reviewed
Feb 3, 2025
lukmzig
reviewed
Feb 3, 2025
lukmzig
reviewed
Feb 3, 2025
lukmzig
reviewed
Feb 3, 2025
lukmzig
reviewed
Feb 3, 2025
lukmzig
reviewed
Feb 3, 2025
lukmzig
reviewed
Feb 3, 2025
lukmzig
requested changes
Feb 3, 2025
Contributor
lukmzig
left a comment
lukmzig
left a comment
There was a problem hiding this comment.
In general it seems like that controllers are missing some default responses and maybe we can double-check the exceptions which are referenced by the doc blocks.
Also I noticed we are not always checking IsGranted on the endpoints but maybe that on purpose?
lukmzig
reviewed
Feb 3, 2025
lukmzig
reviewed
Feb 3, 2025
Co-authored-by: lukmzig <30526586+lukmzig@users.noreply.github.com>
…ayouts' into 658-task-data-objects---custom-layouts
…ayouts' into 658-task-data-objects---custom-layouts # Conflicts: # src/Class/Repository/CustomLayoutRepository.php
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #658
Additional info
Depends on pimcore/static-resolver-bundle#89
Depends on pimcore/static-resolver-bundle#90