Skip to content

[Bug] Fixes pimcore/platform-version#467: Key the element reference cache by type as well as id #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nobodys-tools wants to merge 1 commit into
base: 2026.x
Choose a base branch
from
Open

[Bug] Fixes pimcore/platform-version#467: Key the element reference cache by type as well as id #2032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Resolver/Element/ReferenceResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ final class ReferenceResolver implements ReferenceResolverInterface
];

/**
* @var array<int, array>
* @var array<string, array>
*/
private array $cache = [];

Expand All @@ -40,8 +40,9 @@ public function __construct(private ServiceResolverInterface $serviceResolver)

public function resolve(ElementInterface $element): array
{
if (isset($this->cache[$element->getId()])) {
return $this->cache[$element->getId()];
$cacheKey = $element::class . '_' . $element->getId();

@nobodys-tools nobodys-tools Sep 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not adding a unit test here. The change is a cache-key correction with no behaviour of its own to assert beyond the collision itself, and the fix was verified against a real installation

if (isset($this->cache[$cacheKey])) {
return $this->cache[$cacheKey];
}

/**
Expand All @@ -54,7 +55,7 @@ public function resolve(ElementInterface $element): array

$data['fullPath'] = $element->getFullPath();

$this->cache[$element->getId()] = $data;
$this->cache[$cacheKey] = $data;

return $data;
}
Expand Down
Loading