[Bug]: mutation must have unique named fields from objectbrick #894

Activity

1. LeonNoBears

   added

   Bug

   on Oct 11, 2024
2. br33f commented on Oct 24, 2024

   

   br33f

   on Oct 24, 2024

   More actions

   Does anyone have a workaround for this one?
3. br33f commented on Oct 25, 2024

   

   br33f

   on Oct 25, 2024

   Last edited by br33f

   More actions

   @LeonNoBears
   Here is how I fixed this problem (at least temporarly):

   In file \Pimcore\Bundle\DataHubBundle\GraphQL\DataObjectMutationFieldConfigGenerator\Table::getGraphQlMutationFieldConfig

   public function getGraphQlMutationFieldConfig($nodeDef, $class, $container = null, $params = [])
       {
           $fieldName = $nodeDef['attributes']['attribute'];
           $tableDef = $this->getGraphQlService()->getObjectFieldHelper()->getFieldDefinitionFromKey($class, $fieldName);
           $inputItems = [];
           $numCols = 0;
   
           if ($tableDef instanceof Data\Table) {
               $numCols = (int) $tableDef->getCols();
           }
   
           $this->getProcessors($processors, $tableDef);
   
           $processor = new \Pimcore\Bundle\DataHubBundle\GraphQL\DataObjectInputProcessor\Table($nodeDef, $processors);
           $processor->setGraphQLService($this->getGraphQlService());
   
           foreach (range(0, $numCols - 1) as $i) {
               $inputItems['col' . $i] = Type::string();
           }
          // Here the changes start
   
           $dataTypes = $this->getGraphQlService()->getDataObjectDataTypes();
   
           $rowInput = array_key_exists('row_input', $dataTypes)
               ? $dataTypes['row_input']
               : new InputObjectType([
                   'name' => 'RowInput',
                   'fields' => $inputItems,
               ]);
   
           $inputType = array_key_exists('table_input', $dataTypes)
               ? $dataTypes['table_input']
               : new InputObjectType([
                   'name' => 'TableInput',
                   'fields' => [
                       'replace' => [
                           'type' => Type::boolean(),
                           'description' => 'if true then the entire table will be overwritten',
                       ],
                       'rows' => [
                           'type' => Type::listOf($rowInput),
                       ],
                   ],
               ]);
   
           if (!array_key_exists('row_input', $dataTypes) && !array_key_exists('table_input', $params) ) {
               $newDataTypes = [
                   'row_input' => $rowInput,
                   'table_input' => $inputType
               ];
   
               $this->getGraphQlService()->registerDataObjectDataTypes($dataTypes + $newDataTypes);
           }
   
           return [
               'arg' => $inputType,
               'processor' => [$processor, 'process'],
           ];
       }
   

   This problem is also present in "Image Gallery" and can be fixed analogically.

   Basically, if you reuse the same "name" you should make sure to also use the exact same instance. Originally for each new field of type "Table" or "Image gallery" new instance of InputObjectType was created. And if different instances share the same "name", then: \GraphQL\Utils\TypeInfo::extractTypes throws an exception.
4. github-actions commented on Nov 15, 2024

   

   github-actionsbot

   on Nov 15, 2024 – with GitHub Actions

   Contributor

   More actions

   Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.
5. github-actions

   added

   PR Welcome

   on Nov 15, 2024