[2FA] Set default issuer to "Pimcore" instead of "Pimcore 2 Factor Authentication"

[BlackbitDevs]

Currently the QR code for 2FA is set to "Pimcore 2 Factor Authentication" by default. This is not optimal because:

1. All applications in Google Authenticator app are 2 factor authentications, so it does not make sense to write this information
2. The string "Pimcore 2 Factor Authentication" is so long that the actual project name is not visible on most mobile phones (in portrait mode) - even if you rename the application in Google Authenticator, the issuer name is kept. Thus if you have multiple Pimcore systems in Authenticator app, you always have to use landscape mode to see which Pimcore app to use

With this PR, the issuer name gets changed to "Pimcore". So by default the app in Google Authenticator would get named

Pimcore: username@Pimcore

If you change the app name in Authenticator, you will still have

Pimcore: App name

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[kingjia90]

Thank you, agree, in addition, seeing a 2 after Pimcore mislead me for Pimcore v2.0 😄 a literal two would have been better.

The question now is, should it be in a bugfix branch as Task or is something should be in a minor? Shouldn't be bc-breaking, right?

[jdreesen]

I think it's just the name of the issuer in the QR code. So it is only used when 2FA is set up by a user. The value can be changed by the user in their 2FA app anyway. So I don't think this is breaking.

[BlackbitDevs]

Exactly, this is not a BC break.

@jdreesen

The value can be changed by the user in their 2FA app anyway.

Sadly, this is not completely true. At least in Google Authenticator when you rename an item, you can only rename the server_name part but not the issuer part from

admin-ui-classic-bundle/config/pimcore/two_factor_authentication.yaml

Lines 5 to 6 in e3b66fb

	server_name: Pimcore # Server name used in QR code
	issuer: Pimcore 2 Factor Authentication # Issuer name used in QR code

(This is what it makes it so annoying because in portrait mode, I only see loads of "Pimcore 2 Factor Authentication: " and then the first 3 characters which I can rename) - and always have tu turn my phone to landscape mode to see the full names.

[robertSt7]

@BlackbitDevs Thanks for the improvement