resolve npm reports on supertest security risk #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on CI results, it appears this dependency tree would require Node.js v4.9+. In fact, updating the rest of the dependency tree for the other CVE's would require Node.js 6.16+. Given that Node.js has dropped security support for these legacy versions, I suggest we go ahead and update the Travis configuration accordingly. |
|
See #182 |
|
Security issues in dev dependencies do not effect end users, as they are not installed when on does "npm install hbs". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve NPM security reports on supertest dependency.
supertest 3.0.0 would have been sufficient, but we might as well keep up with the latest major release, in order to resolve further security warnings more quickly.