fix: gracefully handle when handling an error and socket is null - #57
Merged
Conversation
Closed
wesleytodd
force-pushed
the
no-socket
branch
2 times, most recently
from
September 1, 2024 14:33
c6b9d3d to
30a8271
Compare
blakeembrey
approved these changes
Sep 1, 2024
46 tasks
wesleytodd
force-pushed
the
no-socket
branch
from
September 2, 2024 16:08
30a8271 to
098e71a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
req.socketcan be set to null in some circumstances (see #42). This adds a check for this case which only occurs when an error is raised and the socket is already nulled out.