Skip to content

remove warning when used with HTTP2 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@ var parseUrl = require('parseurl')
var statuses = require('statuses')
var unpipe = require('unpipe')

var http2
try {
http2 = require('http2')
} catch (e) {
http2 = null
}

/**
* Module variables.
* @private
Expand Down Expand Up @@ -276,7 +283,9 @@ function send (req, res, status, headers, message) {

// response status
res.statusCode = status
res.statusMessage = statuses[status]
if (!isHTTP2Response(res)) {
res.statusMessage = statuses[status]
}

// response headers
setHeaders(res, headers)
Expand Down Expand Up @@ -329,3 +338,14 @@ function setHeaders (res, headers) {
res.setHeader(key, headers[key])
}
}

/**
* Check if a response object is HTTP2.
*
* @param {OutgoingMessage|Http2ServerResponse} res
* @private
*/

function isHTTP2Response (res) {
return http2 && res instanceof http2.Http2ServerResponse
}
30 changes: 30 additions & 0 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -513,3 +513,33 @@ describe('finalhandler(req, res)', function () {
})
})
})

describe('HTTP2', function () {
it('should not set statusMessage for HTTP2 response', function (done) {
var http2
try {
http2 = require('http2')
} catch (e) {
return done()
}

process.once('warning', function (warning) {
assert.fail(warning)
})

var server = http2.createServer(function (req, res) {
var done = finalhandler(req, res)
done()
})

server.listen(function () {
var address = server.address()
var client = http2.connect('http://localhost:' + address.port)
client.request({ ':path': '/' }).on('response', function () {
client.close()
server.close()
done()
})
})
})
})