Skip to content

Oof, paper engine msg fixes after using msgspec.Struct.. #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goodboy merged 1 commit into from
Jul 11, 2022
Merged

Oof, paper engine msg fixes after using msgspec.Struct.. #357

goodboy merged 1 commit into from
Jul 11, 2022

Conversation

@goodboy
Copy link
Contributor

@goodboy goodboy commented Jul 11, 2022

Hot fixes for the paper engine.

Not sure how I didn't catch this landing #353 ..

More or less we had fields that weren't defined being passed in..
Good emphasis on why pydantic was kinda, bleh.

@goodboy goodboy requested a review from guilledk July 11, 2022 17:06
@goodboy goodboy merged commit f449672 into master Jul 11, 2022
@goodboy goodboy deleted the paper_eng_msg_fixes branch July 11, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guilledk guilledk guilledk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goodboy @guilledk