Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KV put stores value with quotes #68

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

theirix
Copy link

@theirix theirix commented Nov 15, 2022

Allows to put unmodified data to Consul KV. Currently written value is always quoted.

Closes #49

@pierresouchay
Copy link
Owner

Hello @theirix,

This is a very nice change (and it should have been done that way from scratch).

This is also unfortunately a breaking change for people relying on the old behavior for put.

So, I would just change this PR to add a new method (and mark the old one as deprecated) and keep put with existing behavior and marking it as deprecated.

Other possible change, we increase the version number semantically and explain in changelog this is a breaking change.

Regards

@theirix
Copy link
Author

theirix commented Jan 5, 2023

Hello, @pierresouchay . Thank you for reviewing the PR. You are right, original KV::put should be kept for compatibility. I have added a new KV::put_raw for updated behaviour. Original KV::put can be used as a public API and in other modules like catalog where JSON serialization is needed (so no need in deprecation).

@theirix
Copy link
Author

theirix commented May 13, 2024

Hi Pierre,
Could this improvement be merged? It's backwards compatible, so we don't even need to break semantic versioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KV put stores value with quotes
2 participants