Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement agent service register & deregister. fix request parse json error #63

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

uxgnaw
Copy link

@uxgnaw uxgnaw commented May 29, 2021

No description provided.

@pierresouchay
Copy link
Owner

Hello @uxgnaw ,

Thanks a lot for the contribution. There are a few issues however:

Some of the fields are Optional:

  • Address (definitely optional as it overrides the node address
  • Port (even if few services are configured without any port)
  • ID...
  • weights (I care much about this one)

I also think we probably need one structure for registration and another for read as the semantics are sometimes a bit different.

We also have to deal with token to allow registration of such service since several tokens might be required depending of the service being registered as well as handling checks (you can ignore Check alone and handle only Checks)

I also activated the CI, so now, you'll have the CI running

Kind Regards

@uxgnaw
Copy link
Author

uxgnaw commented May 29, 2021

i agree with you. it's not 100% implement.
we can have features fisrt.
this is work for my situation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants