Skip to content

Comments

fix: point to the correct sideeffect file#333

Merged
SlexAxton merged 1 commit intopierrecomputer:mainfrom
BlankParticle:blank/fix/side-effect
Feb 13, 2026
Merged

fix: point to the correct sideeffect file#333
SlexAxton merged 1 commit intopierrecomputer:mainfrom
BlankParticle:blank/fix/side-effect

Conversation

@BlankParticle
Copy link
Contributor

@BlankParticle BlankParticle commented Feb 13, 2026

Description

change the sideEffects array in package json to point to the correct built file

Motivation & Context

I was trying to use @pierre/diffs with vite(@beta, v8), it works really nice in dev, but then when I build it the diffs dont work. I debuged it to find out the code for registering the web component is not included as its a sideeffect and the file is not included in the side effects array, I patched the package json to point to the correct file in node_modules and it worked like a charm

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality). You must have
    first discussed with the dev team and they should be aware that this PR is
    being opened
  • Breaking change (fix or feature that would change existing functionality).
    You must have first discussed with the dev team and they should be aware
    that this PR is being opened
  • Documentation update

Checklist

  • I have read the
    contributing guidelines

  • My code follows the code style of the project (bun run lint)

  • My code is formatted properly (bun run format)

  • I have updated the documentation accordingly (if applicable)

  • I have added tests to cover my changes (if applicable)

  • All new and existing tests pass (bun run diffs:test)

  • Lint shows pre existing errors

  • the test script doesn't exists

How was AI used in generating this PR

I used gpt-codex-5.3 in Opencode to debug this issue, manually tested the patch with pnpm patch

Related issues

@vercel
Copy link

vercel bot commented Feb 13, 2026

@BlankParticle is attempting to deploy a commit to the Pierre Computer Company Team on Vercel.

A member of the Team first needs to authorize it.

@SlexAxton SlexAxton merged commit 28f607e into pierrecomputer:main Feb 13, 2026
6 of 8 checks passed
@BlankParticle BlankParticle deleted the blank/fix/side-effect branch February 13, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants