fix: point to the correct sideeffect file#333
Merged
SlexAxton merged 1 commit intopierrecomputer:mainfrom Feb 13, 2026
Merged
Conversation
|
@BlankParticle is attempting to deploy a commit to the Pierre Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
SlexAxton
approved these changes
Feb 13, 2026
amadeus
pushed a commit
that referenced
this pull request
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
change the sideEffects array in package json to point to the correct built file
Motivation & Context
I was trying to use
@pierre/diffswith vite(@beta, v8), it works really nice in dev, but then when I build it the diffs dont work. I debuged it to find out the code for registering the web component is not included as its a sideeffect and the file is not included in the side effects array, I patched the package json to point to the correct file in node_modules and it worked like a charmType of changes
first discussed with the dev team and they should be aware that this PR is
being opened
You must have first discussed with the dev team and they should be aware
that this PR is being opened
Checklist
I have read the
contributing guidelines
My code follows the code style of the project (
bun run lint)My code is formatted properly (
bun run format)I have updated the documentation accordingly (if applicable)
I have added tests to cover my changes (if applicable)
All new and existing tests pass (
bun run diffs:test)Lint shows pre existing errors
the test script doesn't exists
How was AI used in generating this PR
I used gpt-codex-5.3 in Opencode to debug this issue, manually tested the patch with
pnpm patchRelated issues